Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow batches structured types #1879

Merged

Conversation

sfc-gh-astachowski
Copy link
Collaborator

Overview

Added support for structured types (vector, list, map, struct)

Pre-review self checklist

  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)

Base automatically changed from arrow-batches-initial to SNOW-873466-arrow-batches August 30, 2024 11:44
@sfc-gh-astachowski sfc-gh-astachowski marked this pull request as ready for review September 3, 2024 14:22
@sfc-gh-astachowski sfc-gh-astachowski requested a review from a team as a code owner September 3, 2024 14:22
…d-types

# Conflicts:
#	src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverter.java
…d-types

# Conflicts:
#	src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverterUtil.java
#	src/test/java/net/snowflake/client/jdbc/ArrowBatchesIT.java
Copy link
Collaborator

@sfc-gh-pbulawa sfc-gh-pbulawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some tests asserting the SFArrowException behavior.

@sfc-gh-astachowski sfc-gh-astachowski merged commit 8c209d2 into SNOW-873466-arrow-batches Oct 16, 2024
5 of 7 checks passed
@sfc-gh-astachowski sfc-gh-astachowski deleted the arrow-batches-structured-types branch October 16, 2024 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants