Add grants support to Streamlit entity #1981
Merged
+96
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-astus
reviewed
Jan 9, 2025
|
Duplicate #1967 ? |
sfc-gh-turbaszek
force-pushed
the
add-grants-for-streamlit
branch
from
242c0ad to
b10eef2
Compare
Comment on lines
+257
to
+258
| for grant in entity_model.grants: | ||
| self.execute_query(grant.get_grant_sql(entity_model)) |
There was a problem hiding this comment.
Small improvement: execute all grants in single query
sfc-gh-astus
approved these changes
Jan 24, 2025
| class GrantBaseModel(UpdatableModel): | ||
| grants: Optional[List[Grant]] = Field(title="List of grants", default=None) | ||
|
|
||
| def get_grant_sqls(self) -> list[str]: |
There was a problem hiding this comment.
I think we should add this to StreamlitEntity.get_grant_sql
This was referenced Jan 24, 2025
| role: str = Field(title="Role to which the privileges will be granted") | ||
|
|
||
| def get_grant_sql(self, entity_model: EntityModelBase) -> str: | ||
| return f"GRANT {self.privilege} ON {entity_model.get_type().upper()} {entity_model.fqn.sql_identifier} TO ROLE {self.role}" |
There was a problem hiding this comment.
In relation to my PR #1967 , will this allow the ability to grant share privileges on a Streamlit app? It appears Streamlit uses WITH GRANT OPTION to achieve this today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
...