Add snowpark entities #1959
Open
Add snowpark entities #1959
+522
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntities # Conflicts: # tests/streamlit/__snapshots__/test_commands.ambr # tests/test_data/projects/example_streamlit_v2/snowflake.yml
…tities_basic # Conflicts: # src/snowflake/cli/_plugins/streamlit/streamlit_entity.py
Closed
5 tasks
|
|
||
| T = TypeVar("T") | ||
|
|
||
|
|
||
| class DeployMode( |
There was a problem hiding this comment.
Suggested change
| class DeployMode( | |
| class CreateMode( |
WDYT?
| if not FeatureFlag.ENABLE_NATIVE_APP_CHILDREN.is_enabled(): | ||
| raise NotImplementedError("Snowpark entity is not implemented yet") |
There was a problem hiding this comment.
What's the reasoning behind this flag?
There was a problem hiding this comment.
It was introduced in #1856
As we are not introducing entities in commands just yet, it seems reasonable to turn them off by default.
| super().__init__(*args, **kwargs) | ||
|
|
||
| @property | ||
| def root(self): |
There was a problem hiding this comment.
Please add type hints
Comment on lines
49
to
69
| @property | ||
| def identifier(self): | ||
| return self.model.fqn.sql_identifier | ||
|
|
||
| @property | ||
| def fqn(self): | ||
| return self.model.fqn | ||
|
|
||
| @functools.cached_property | ||
| def _sql_executor( | ||
| self, | ||
| ): # maybe this could be moved to parent class, as it is used in streamlit entity as well | ||
| return get_sql_executor() | ||
|
|
||
| @functools.cached_property | ||
| def _conn(self): | ||
| return self._sql_executor._conn # noqa | ||
|
|
||
| @property | ||
| def model(self): | ||
| return self._entity_model # noqa |
There was a problem hiding this comment.
Probably those properties can be move to some generic class, wdyt?
| allow_shared_libraries: bool = False, | ||
| *args, | ||
| **kwargs, | ||
| ): |
There was a problem hiding this comment.
Please add type hint
| self, action_ctx: ActionContext, mode: DeployMode, *args, **kwargs | ||
| ): | ||
| # TODO: After introducing bundle map, we should introduce file copying part here | ||
| return self._sql_executor.execute_query(self.get_deploy_sql(mode)) |
There was a problem hiding this comment.
There's a bit of repetition in this approach:
Suggested change
| return self._sql_executor.execute_query(self.get_deploy_sql(mode)) | |
| return self._sql_executor.execute_query(self.get_deploy_sql(mode)) |
have you considered something like
self._execute(self.get_deploy_sql(mode))
or builder pattern:
self.get_deploy_sql(mode).execute()
WDYT?
| def get_execute_sql(self, execution_arguments: List[str] | None = None): | ||
| raise NotImplementedError | ||
|
|
||
| def get_usage_grant_sql(self, app_role: str): |
There was a problem hiding this comment.
Suggested change
| def get_usage_grant_sql(self, app_role: str): | |
| def get_usage_grant_sql(self, role: str): |
There's nothing app specific in this query as far as I can tell
Comment on lines
197
to
207
| def get_describe_sql(self): | ||
| return f"DESCRIBE {self.model.type.upper()} {self.identifier}" | ||
|
|
||
| def get_drop_sql(self): | ||
| return f"DROP {self.model.type.upper()} {self.identifier}" | ||
|
|
||
| def get_execute_sql(self, execution_arguments: List[str] | None = None): | ||
| raise NotImplementedError | ||
|
|
||
| def get_usage_grant_sql(self, app_role: str): | ||
| return f"GRANT USAGE ON {self.model.type.upper()} {self.identifier} TO ROLE {app_role}" |
There was a problem hiding this comment.
Good candidates to extract to parent, generic class.
sfc-gh-jsikorski
force-pushed
the
jsikorski/snowpark_entities_basic
branch
from
762aa80 to
801b67d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Basic implementation of snowpark entities - to be updated after introducing bundle map for all entities.