SNOW-1706990 Convert test_manager.py to use v2 entities #1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -266,7 +272,7 @@ def action_validate( | |||
| post_deploy_hooks=model.meta and model.meta.post_deploy, | |||
| package_scripts=[], # Package scripts are not supported in PDFv2 | |||
| policy=policy, | |||
| use_scratch_stage=True, | |||
| use_scratch_stage=use_scratch_stage, | |||
There was a problem hiding this comment.
had to make this a param since we want False in tests
There was a problem hiding this comment.
why is that? Didn't get it from the diff.
There was a problem hiding this comment.
in tests we don't want to call deploy() on the package, so we need to be able to pass False here. In the old NativeAppManager.validate(), the use_scratch_stage parameter defaults to False:
There was a problem hiding this comment.
this doesn't change prod code since the parameter now defaults to True in v2, the same value that was hardcoded here before
sfc-gh-bdufour
approved these changes
Oct 15, 2024
sfc-gh-mchok
pushed a commit
that referenced
this pull request
Oct 15, 2024
Updates tests in `test_manager.py` to use a v2 test project and call out to the v2 entities directly instead of going through the `NativeAppManager`. I've kept the diff as simple as possible and avoided introducing too many helpers or reorganizing the code, that can be done separately if necessary (the top priority is to just work towards removing `NativeAppManager` and all these static methods first).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Updates tests in
test_manager.pyto use a v2 test project and call out to the v2 entities directly instead of going through theNativeAppManager. I've kept the diff as simple as possible and avoided introducing too many helpers or reorganizing the code, that can be done separately if necessary (the top priority is to just work towards removingNativeAppManagerand all these static methods first).