Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snow git execute for Python files #1666

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Fix snow git execute for Python files #1666

merged 5 commits into from
Oct 16, 2024
+229 −86

Conversation

sfc-gh-turbaszek
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Fix snow git execute for Python files:

  1. Copy the files first to temporary stage to workaround missing Snow git feature
  2. Strip leading and trailing quotes from input variables so the values are consistent between SQL and Python
  3. Add support for temporary stage in StageManager

@sfc-gh-turbaszek sfc-gh-turbaszek requested review from a team as code owners October 3, 2024 15:39
sfc-gh-astus
sfc-gh-astus previously approved these changes Oct 3, 2024
View reviewed changes
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit d8cf03f into main Oct 16, 2024
21 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the fix-git-execute branch October 16, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-turbaszek @sfc-gh-astus