Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1706990 Rename v2_to_v1_decorator.py to compat.py #1658

Merged
merged 1 commit into from
Oct 2, 2024
Merged

SNOW-1706990 Rename v2_to_v1_decorator.py to compat.py #1658

merged 1 commit into from
Oct 2, 2024

Conversation

sfc-gh-fcampbell
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Extracted from #1635

Renames snowflake.cli._plugins.nativeapp.v2_conversions.v2_to_v1_decorator to snowflake.cli._plugins.nativeapp.v2_conversions.compat since we're going to put more stuff in there.

@sfc-gh-fcampbell sfc-gh-fcampbell changed the title Pass context in entity init instead of only to actions Rename v2_to_v1_decorator.py to compat.py Oct 2, 2024
@sfc-gh-fcampbell sfc-gh-fcampbell changed the title Rename v2_to_v1_decorator.py to compat.py SNOW-1706990 Rename v2_to_v1_decorator.py to compat.py Oct 2, 2024
@sfc-gh-fcampbell sfc-gh-fcampbell marked this pull request as ready for review October 2, 2024 16:20
@sfc-gh-fcampbell sfc-gh-fcampbell requested a review from a team as a code owner October 2, 2024 16:20
sfc-gh-bdufour
sfc-gh-bdufour previously approved these changes Oct 2, 2024
View reviewed changes
@sfc-gh-fcampbell sfc-gh-fcampbell requested a review from a team as a code owner October 2, 2024 18:59
@sfc-gh-fcampbell sfc-gh-fcampbell changed the base branch from frank-action-context-init to main October 2, 2024 19:00
@sfc-gh-fcampbell sfc-gh-fcampbell dismissed sfc-gh-bdufour’s stale review October 2, 2024 19:00

The base branch was changed.

@sfc-gh-fcampbell sfc-gh-fcampbell enabled auto-merge (squash) October 2, 2024 19:00
@sfc-gh-fcampbell sfc-gh-fcampbell merged commit 205fce0 into main Oct 2, 2024
19 checks passed
@sfc-gh-fcampbell sfc-gh-fcampbell deleted the frank-rename-compat branch October 2, 2024 19:30
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-fcampbell
SNOW-1706990 Rename v2_to_v1_decorator.py to compat.py (#1658)
914f7bd 
Renames `snowflake.cli._plugins.nativeapp.v2_conversions.v2_to_v1_decorator` to `snowflake.cli._plugins.nativeapp.v2_conversions.compat` since we're going to put more stuff in there.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdufour sfc-gh-bdufour sfc-gh-bdufour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-fcampbell @sfc-gh-bdufour