Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1694005: MacOS binary signing #1640

Merged
merged 37 commits into from
Oct 3, 2024
Merged

SNOW-1694005: MacOS binary signing #1640

merged 37 commits into from
Oct 3, 2024

Conversation

sfc-gh-mraba
Copy link
Contributor

@sfc-gh-mraba sfc-gh-mraba commented Sep 30, 2024 •
edited by jira bot
Loading

SNOW-1694005

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Combined building binaries and pkg with pyinstaller.
Solved problem with signing multpile linked Python binaries

@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1694005-macos-binary-signing branch 2 times, most recently from c7e5565 to 30ee0e6 Compare September 30, 2024 18:39
@sfc-gh-mraba sfc-gh-mraba self-assigned this Oct 1, 2024
@sfc-gh-mraba sfc-gh-mraba marked this pull request as ready for review October 1, 2024 19:37
@sfc-gh-mraba sfc-gh-mraba requested a review from a team as a code owner October 1, 2024 19:37
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1694005-macos-binary-signing branch from 64fbb48 to 612dd92 Compare October 2, 2024 08:09
@sfc-gh-mraba
SNOW-1694005: fix executable path
e08ea67
@sfc-gh-mraba
SNOW-1694005: fix executable path
764611a
@sfc-gh-mraba
SNOW-1694005: organize signign funcs
e02a366
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo
1fb17ff
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 2
16a753e
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 3
4ddb7e8
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 4
4b80857
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 5
8faebca
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 6
89771d0
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 7
e7c3189
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 8
132b2f2
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 9
2b86d33
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 10
0f5bb99
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 11
20104e6
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 12
2ba40bd
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 13
ea5e46d
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 14
0ac6156
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 15
81a15d0
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 16
6f514bb
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 17
d6ae21d
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 18
13dfabb
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 19
6e8623d
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 20
321ca02
@sfc-gh-mraba
SNOW-1694005: organize signign funcs fix typo 21
dcf282c
@sfc-gh-mraba sfc-gh-mraba force-pushed the SNOW-1694005-macos-binary-signing branch from 8f840c7 to c888e09 Compare October 3, 2024 14:19
@sfc-gh-mraba sfc-gh-mraba enabled auto-merge (squash) October 3, 2024 14:39
@sfc-gh-mraba sfc-gh-mraba merged commit 917e5cc into main Oct 3, 2024
20 of 21 checks passed
@sfc-gh-mraba sfc-gh-mraba deleted the SNOW-1694005-macos-binary-signing branch October 3, 2024 14:47
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-mraba
SNOW-1694005: MacOS binary signing (#1640)
5b8b5d2 
* SNOW-1694005: use pyinstaller for composing pkg content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees

@sfc-gh-mraba sfc-gh-mraba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-mraba @sfc-gh-astus