Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency ws to 7.4.6 [SECURITY] #819

Merged
merged 1 commit into from
Aug 14, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 29, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change
ws 7.2.5 -> 7.4.6

GitHub Vulnerability Alerts

CVE-2021-32640

Impact

A specially crafted value of the Sec-Websocket-Protocol header can be used to significantly slow down a ws server.

Proof of concept

for (const length of [1000, 2000, 4000, 8000, 16000, 32000]) {
  const value = 'b' + ' '.repeat(length) + 'x';
  const start = process.hrtime.bigint();

  value.trim().split(/ *, */);

  const end = process.hrtime.bigint();

  console.log('length = %d, time = %f ns', length, end - start);
}

Patches

The vulnerability was fixed in [email protected] (websockets/ws@00c425e) and backported to [email protected] (websockets/ws@78c676d) and [email protected] (websockets/ws@76d47c1).

Workarounds

In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the --max-http-header-size=size and/or the maxHeaderSize options.

Credits

The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.


Configuration

📅 Schedule: "" (UTC).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch from f975151 to 46de3bb Compare June 1, 2021 17:21
@renovate renovate bot changed the title Update dependency ws to 7.4.6 [SECURITY] Update dependency ws to 7.4.6 [SECURITY] - autoclosed Jun 1, 2021
@renovate renovate bot closed this Jun 1, 2021
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch June 1, 2021 21:24
@renovate renovate bot changed the title Update dependency ws to 7.4.6 [SECURITY] - autoclosed Update dependency ws to 7.4.6 [SECURITY] Jun 2, 2021
@renovate renovate bot reopened this Jun 2, 2021
@renovate renovate bot restored the renovate/npm-ws-vulnerability branch June 2, 2021 07:55
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 11 times, most recently from 4a7f3b8 to 63b89de Compare June 8, 2021 03:21
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 7 times, most recently from 3b34618 to c387d51 Compare June 15, 2021 00:41
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 4 times, most recently from e7f6677 to 2f89a66 Compare June 18, 2021 23:22
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 10 times, most recently from 45a544d to b751d47 Compare August 2, 2021 15:01
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 9 times, most recently from 3a94afc to c0e6cfb Compare August 11, 2021 05:15
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch 7 times, most recently from fac15a5 to cefc1d0 Compare August 14, 2021 20:43
@renovate renovate bot force-pushed the renovate/npm-ws-vulnerability branch from cefc1d0 to 799dd59 Compare August 14, 2021 21:27
@renovate renovate bot merged commit e5c88d3 into master Aug 14, 2021
@renovate renovate bot deleted the renovate/npm-ws-vulnerability branch August 14, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant