Changed 'aria2c --version' to 'LANG=en_US.UTF-8 aria2c --version' for consistent environment #495
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my environment,
$LANG=ja_JP.UTF-8
is set by default and the output ofaria2c --version
is in Japanese.In that case, the value of the
aria2Ver
is "aria2 バージョン" instead of "aria2 version", which does not matchversionRegex = RegExp(/aria2 version (. *)/)
and followiing process throws an error.destreamer/src/Utils.ts
Lines 216 to 229 in e93ad80
To solve this problem, change
execSync('aria2c --version')
toexecSync('LANG=en_US.UTF-8 aria2c --version')
so that the output of the commandaria2c --version
is always in English.