-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aria2c, but for real now #220
Draft
lukaarma
wants to merge
69
commits into
v3.0
Choose a base branch
from
aria2c_forRealNow
base: v3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added debug logging
- added filename property to Video type
- fixed comments
fixed typo
made videos path clear
made videos path clearer
Update README.md
* cleared up docs * fix 401 bug for images thumbnail
(should solve and close #254)
Fix typo in `MISSING_ARIA2` and some capitalization
Fix typo and capitalization in Errors.ts
SO to make this stable and ready for master we are still missing all the documentation and the error handling, @snobu if you have some time free please let e know via mail so we can do a sprint to finish this maybe |
Which i guess was like 99% of the time? :)
fixed error logging
Added a prerequisite for the `aria2` package to be installed when using this version.
Added `aria2` prerequisite
Update prereqs and fix quotes in readme.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First we approve this then I'll work on the other items in the project @snobu
TODOs
There are some FIXME/TODOS but it works!
And you don't have any idea how fast it really is