Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CE due to missing snitch_main.hpp #200

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix CE due to missing snitch_main.hpp #200

merged 2 commits into from
Dec 2, 2024

Conversation

tocic
Copy link
Member

@tocic tocic commented Dec 1, 2024

Closes #199.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (f40e2df) to head (d11ca82).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          30       30           
  Lines        1754     1754           
=======================================
  Hits         1649     1649           
  Misses        105      105           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f40e2df...d11ca82. Read the comment docs.

@cschreib
Copy link
Member

cschreib commented Dec 1, 2024

Nice catch, thanks. I've modified the install tests to use snitch.hpp instead of individual headers. Next time this happens, we'll catch it before release.

@tocic tocic merged commit 2a59433 into main Dec 2, 2024
45 checks passed
@tocic tocic deleted the fix_snitch_main_hpp_CE branch December 2, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snitch 1.3.0: fatal error: snitch/snitch_main.hpp: No such file or directory
2 participants