Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REQUIRE_THROWS_MATCHES and CHECK_THROWS_MATCHES do not preserve matcher state #68

Closed
cschreib opened this issue Feb 2, 2023 · 0 comments · Fixed by #69
Closed

REQUIRE_THROWS_MATCHES and CHECK_THROWS_MATCHES do not preserve matcher state #68

cschreib opened this issue Feb 2, 2023 · 0 comments · Fixed by #69
Labels
bug:confirmed Something isn't working (confirmed)
Milestone
v1.1.0

Comments

@cschreib
Copy link
Member

cschreib commented Feb 2, 2023

The matcher API claims that the matcher object is reused between the calls to match and describe_match, but this is not done in REQUIRE_THROWS_MATCHES and CHECK_THROWS_MATCHES; a new matcher object is created for each call.
@cschreib cschreib added the bug:unconfirmed Something isn't working (to be confirmed) label Feb 2, 2023
@cschreib cschreib added this to the v1.x milestone Feb 2, 2023
cschreib added a commit that referenced this issue Feb 2, 2023
@cschreib
Fix #61, #67, #68
a47bf15
@cschreib cschreib mentioned this issue Feb 2, 2023
Merged
@cschreib cschreib added bug:confirmed Something isn't working (confirmed) and removed bug:unconfirmed Something isn't working (to be confirmed) labels May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:confirmed Something isn't working (confirmed)
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging a pull request may close this issue.

Fix several bugs related to macro expansions snitch-org/snitch
1 participant
@cschreib