Lakos rule: remove noexcept because of narrow contract

snitch-org · May 7, 2024 · 909303e · 909303e
1 parent d91b154
commit 909303e
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 3 deletions.
diff --git a/include/snitch/snitch_string_utility.hpp b/include/snitch/snitch_string_utility.hpp
@@ -54,8 +54,9 @@ constexpr small_string<N> resize_or_truncate(const small_string<M>& str) noexcep
 SNITCH_EXPORT [[nodiscard]] bool replace_all(
     small_string_span string, std::string_view pattern, std::string_view replacement) noexcept;
 
+// Requires: replacement.length() > pattern.length()
 SNITCH_EXPORT [[nodiscard]] bool escape_all_or_truncate(
-    small_string_span string, std::string_view pattern, std::string_view replacement) noexcept;
+    small_string_span string, std::string_view pattern, std::string_view replacement);
 
 SNITCH_EXPORT [[nodiscard]] std::size_t
 find_first_not_escaped(std::string_view str, char c) noexcept;

diff --git a/src/snitch_string_utility.cpp b/src/snitch_string_utility.cpp
@@ -110,10 +110,10 @@ bool replace_all(
 }
 
 bool escape_all_or_truncate(
-    small_string_span string, std::string_view pattern, std::string_view replacement) noexcept {
+    small_string_span string, std::string_view pattern, std::string_view replacement) {
 
     if (replacement.size() <= pattern.size()) {
-        terminate_with("escape_all() requires a replacement that is longer than the pattern");
+        assertion_failed("escape_all() requires a replacement that is longer than the pattern");
     }
 
     const std::size_t char_diff = replacement.size() - pattern.size();

diff --git a/tests/runtime_tests/string_utility.cpp b/tests/runtime_tests/string_utility.cpp
@@ -1,4 +1,5 @@
 #include "testing.hpp"
+#include "testing_assertions.hpp"
 
 #include <cmath>
 
@@ -843,6 +844,14 @@ TEST_CASE("escape_all_or_truncate", "[utility]") {
                 "abaca", "abacaabcdefghijklmqrst", "abcdefghijklmnopqrstabcdefghijklmnopqrst") ==
             e{"abaca", true});
     }
+
+    SECTION("with replacement smaller than pattern") {
+        assertion_exception_enabler enabler;
+
+        CHECK_THROWS_WHAT(
+            escape<5>("abaca", "aa", "a"), assertion_exception,
+            "requires a replacement that is longer than the pattern");
+    }
 }
 
 TEST_CASE("is_match", "[utility]") {