Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to fit SnipsNLUEngine with Dataset object #840

Merged
merged 3 commits into from
Aug 9, 2019
Merged

Allow to fit SnipsNLUEngine with Dataset object #840

merged 3 commits into from
Aug 9, 2019

Conversation

adrienball
Copy link
Contributor

Description:
Allow to fit SnipsNLUEngine with a Dataset object.

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@adrienball adrienball requested a review from ClemDoum August 8, 2019 14:39
@adrienball adrienball mentioned this pull request Aug 8, 2019
Closed
@adrienball adrienball merged commit 829d513 into master Aug 9, 2019
@adrienball adrienball deleted the task/validate-dataset branch August 9, 2019 12:49
@ClemDoum ClemDoum mentioned this pull request Sep 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClemDoum ClemDoum ClemDoum approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrienball @ClemDoum