Avoid generating number variations when not needed #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemDoum
force-pushed
the
task/limit-string-variations
branch
2 times, most recently
from
3f087c6 to
c6c307d
Compare
Codecov Report
@@ Coverage Diff @@
## develop #799 +/- ##
===========================================
+ Coverage 88.38% 88.43% +0.05%
===========================================
Files 76 76
Lines 4570 4573 +3
Branches 882 883 +1
===========================================
+ Hits 4039 4044 +5
+ Misses 398 397 -1
+ Partials 133 132 -1 |
adrienball
requested changes
May 10, 2019
snips_nlu/dataset/validation.py
Outdated
| # values | ||
| number_variations_limit = 0 | ||
| if len(entity[DATA]) < NUMBER_VARIATIONS_THRESHOLD: | ||
| number_variations_limit = None |
There was a problem hiding this comment.
What about using a boolean flag for number_variations_limit ?
ClemDoum
force-pushed
the
task/limit-string-variations
branch
2 times, most recently
from
61c7a51 to
786daca
Compare
ClemDoum
force-pushed
the
task/limit-string-variations
branch
from
786daca to
1b1b27c
Compare
adrienball
approved these changes
May 13, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
After analysis generating number entity values variations when validating the dataset can take a very long time when the entity as a lot of value. This is mostly due to running Rustling on each entity value.
To be able to validate the dataset in a reasonable amount of time, number variations are computed only when there are less than 10000 entity values in the entity data.
Checklist: