Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when re-fitting slot filler #771

Merged
merged 2 commits into from
Mar 13, 2019
Merged

Fix issue when re-fitting slot filler #771

merged 2 commits into from
Mar 13, 2019

Conversation

adrienball
Copy link
Contributor

Description:
This PR fixes an issue which caused a crash when re-fitting a CRFSlotFiller.

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@adrienball adrienball requested a review from ClemDoum March 13, 2019 10:51
@codecov-io
Copy link

Codecov Report

Merging #771 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #771      +/-   ##
===========================================
+ Coverage       88%   88.02%   +0.01%     
===========================================
  Files           76       76              
  Lines         4487     4491       +4     
  Branches       852      853       +1     
===========================================
+ Hits          3949     3953       +4     
  Misses         402      402              
  Partials       136      136

@adrienball adrienball merged commit 0ddd8c1 into develop Mar 13, 2019
@adrienball adrienball deleted the fix/slot-filler branch March 13, 2019 13:34
@adrienball adrienball mentioned this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants