Gazetteer entities #668
Merged
Gazetteer entities #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ances from the NLU serialization
Codecov Report
@@ Coverage Diff @@
## develop #668 +/- ##
===========================================
- Coverage 89.17% 88.95% -0.22%
===========================================
Files 59 64 +5
Lines 3306 3648 +342
Branches 627 672 +45
===========================================
+ Hits 2948 3245 +297
- Misses 258 307 +49
+ Partials 100 96 -4 |
adrienball
force-pushed
the
task/custom-gazetteer-entities
branch
2 times, most recently
from
dbc7c80 to
8d9320c
Compare
adrienball
force-pushed
the
task/custom-gazetteer-entities
branch
from
8d9320c to
2d4aa15
Compare
ClemDoum
approved these changes
Oct 4, 2018
| if ENTITY in chunk: | ||
| entities_values[chunk[ENTITY]].add(chunk[TEXT].strip()) | ||
| return {k: list(v) for k, v in iteritems(entities_values)} | ||
|
|
||
|
|
||
| def extract_intent_entities(dataset, entity_filter=None): | ||
| intent_entities = {intent: set() for intent in dataset[INTENTS]} |
There was a problem hiding this comment.
collections.defaultdict does exactly this
|
🎉 🎉 🎉 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces the use of gazetteer entities through new 3 builtin entities with initial support in French:
snips/musicAlbumsnips/musicArtistsnips/musicTrackA new
CustomEntityParserobject is introduced. It relies on the gazetteer entity parser library, and replaces all the previous logics regarding the matching and the resolution of custom entities.The serialization of the
SnipsNLUEnginehas also evolved, as there are now two new folders:builtin_entity_parsercustom_entity_parserHence, the model version is bumped to
0.17.0.