Add Pull Request template #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClemDoum
requested changes
Aug 13, 2018
.github/PULL_REQUEST_TEMPLATE.md
Outdated
|
|
||
| **Checklist**: | ||
| - [ ] My PR is ready for code review | ||
| - [ ] I have added some tests, if applicable |
There was a problem hiding this comment.
I would add, '"and run the whole test suite"
There was a problem hiding this comment.
I would also add "even linting tests, this way we can get rid of the next point"
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| **Checklist**: | ||
| - [ ] My PR is ready for code review | ||
| - [ ] I have added some tests, if applicable | ||
| - [ ] My code respects the [PEP8 style guide](https://www.python.org/dev/peps/pep-0008/) |
There was a problem hiding this comment.
I don't know if that is necessary. I think that for now we have no guaranty that our current code base is PEP8 compliant. The only thing we know is that the codebase is compliant with the Google-like linting rules that we have in the pylintrc
There was a problem hiding this comment.
Plus, I find it very hard to know if your code is PEP8 compliant from juste the guidelines provided in the URL. The linting test has the advantage to tell you precisely what's wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.