-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a Label Fields vertical adjustment option for Dymo Labelwriters #15863
base: develop
Are you sure you want to change the base?
Added a Label Fields vertical adjustment option for Dymo Labelwriters #15863
Conversation
PR Summary
|
Hmm. The title in the picture is to show that only the fields are moving. I'm not sure? thats another option input that wasn't asked for. Maybe? @snipe what do you think?? |
#APP_LOCALE=en | ||
APP_ENV=develop | ||
APP_DEBUG=false | ||
APP_KEY=base64:WpNieYLCLW/T+VC63PK0ypfNUZ+/zf0V6eG3XIpCCaY= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we want to hardcode app keys here.
@@ -67,6 +67,7 @@ | |||
'favicon' => 'Favicon', | |||
'favicon_format' => 'Accepted filetypes are ico, png, and gif. Other image formats may not work in all browsers.', | |||
'favicon_size' => 'Favicons should be square images, 16x16 pixels.', | |||
'field_margin_top' => 'Field Margin Top', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What unit of measure is this using?
Description
This adds the ability to move the label fields slightly lower than they currently are. Some labels come printed with the logo already and this allows to not print on top of the logo.
The
Field margin Top
input field does not appear for or affect other label types.The max value of the field margin top is 10. ignore the 5 in the pictures.
Standard:
Dymo\LabelWriter_30252
Dymo\LabelWriter_1933081
Dymo\LabelWriter_2112283
Adjustment at max margin adjustment 5:
Dymo\LabelWriter_30252
Dymo\LabelWriter_1933081
Dymo\LabelWriter_2112283
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: