Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a Label Fields vertical adjustment option for Dymo Labelwriters #15863

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Nov 20, 2024

Description

This adds the ability to move the label fields slightly lower than they currently are. Some labels come printed with the logo already and this allows to not print on top of the logo.
The Field margin Top input field does not appear for or affect other label types.
The max value of the field margin top is 10. ignore the 5 in the pictures.

Standard:
Dymo\LabelWriter_30252
image
Dymo\LabelWriter_1933081
image
Dymo\LabelWriter_2112283
image

Adjustment at max margin adjustment 5:
Dymo\LabelWriter_30252
image

Dymo\LabelWriter_1933081
image

Dymo\LabelWriter_2112283
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Nov 20, 2024

PR Summary

  • Enhanced Settings Management
    The functionality of the SettingsController has been improved by accommodating the label_cell_margin_top setting in the postLabels method. This provides finer control over individual label settings within our platform.

  • Label Formatting Improvements
    In LabelWriter classes, we have now made it possible to retrieve label_cell_margin_top from within the settings. This will enable users to adjust the vertical alignment of the fields in their labels. Additionally, the changes ensure that the vertical positioning of text for titles and field values correspond to the new margin setting.

  • Database Upgrade
    A migration file has been introduced to add label_cell_margin_top as a new column in the settings table. This sets the stage for storing and retrieving the new top margin settings for label fields.

  • Language Options Addition
    We have enhanced the language files by adding new language strings for field_margin_top. A help text for label_cell_margin_top is also added to guide users in better understanding the use of this setting.

  • User Interface Enhancement
    In labels.blade.php, a new input field for label_cell_margin_top has been added. This will let users specify the vertical margin for label fields directly from the settings form, offering a more intuitive and user-friendly approach.

@Godmartinz Godmartinz requested review from marcusmoore and snipe and removed request for snipe November 20, 2024 22:20
@marcusmoore
Copy link
Collaborator

Does it make sense for the title to be lowered as well?

label mockup
(mock up)

@Godmartinz
Copy link
Collaborator Author

Hmm. The title in the picture is to show that only the fields are moving. I'm not sure? thats another option input that wasn't asked for. Maybe? @snipe what do you think??

@marcusmoore
Copy link
Collaborator

I'm just wondering if we know for sure the logo that is pre-printed on labels slots in between the title and fields cleanly. Me, without any knowledge of pre-printed labels, would assume it would be here
CleanShot 2024-11-20 at 17 02 33

#APP_LOCALE=en
APP_ENV=develop
APP_DEBUG=false
APP_KEY=base64:WpNieYLCLW/T+VC63PK0ypfNUZ+/zf0V6eG3XIpCCaY=
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to hardcode app keys here.

@@ -67,6 +67,7 @@
'favicon' => 'Favicon',
'favicon_format' => 'Accepted filetypes are ico, png, and gif. Other image formats may not work in all browsers.',
'favicon_size' => 'Favicons should be square images, 16x16 pixels.',
'field_margin_top' => 'Field Margin Top',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What unit of measure is this using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants