Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved speed of sqlite tests in GitHub Actions #15860

Merged

Conversation

marcusmoore
Copy link
Collaborator

@marcusmoore marcusmoore commented Nov 20, 2024

Description

Running sqlite tests in Github Actions is starting to take a while (8 minutes in a recent PR). This PR switches from running them in-memory to using a file on disk and improves the run time (8 minutes -> 1 minute)

Type of change

  • Testing

@marcusmoore marcusmoore requested a review from snipe as a code owner November 20, 2024 20:45
Copy link

what-the-diff bot commented Nov 20, 2024

PR Summary

  • Database File Creation Step Added
    A new step has been introduced to create a database file, making the setup process more streamlined.
  • Database Connection Environment Variable Updated
    The DB_CONNECTION variable has been updated from sqlite_testing to sqlite, aligning it with the standard naming conventions for better clarity.

@snipe snipe merged commit 0a3bca0 into snipe:develop Nov 20, 2024
9 checks passed
@marcusmoore marcusmoore deleted the tests/switch-to-file-for-sqlite-in-action branch November 20, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants