Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed admin user not showing in download all activity report #15828

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Nov 15, 2024

This fixes the regression where the admin user's name was being omitted from the Activity Report > Download All, reported via Discord.

Copy link

what-the-diff bot commented Nov 15, 2024

PR Summary

  • Improving Data Fetching Efficiency - The Actionlog model now includes 'adminuser' in its eager loading mechanism. This change helps to reduce the amount of queries required when using the Actionlog model, which can improve overall system performance.
  • Update in Data Access Method - Revised the way we access specific data from the Actionlog. Previously, we used $actionlog->admin to retrieve the full name attribute for action logs. We've updated this to now use $actionlog->adminuser. This aligns with the new way we load data, ensuring a smoother, more efficient access to the data we require.

@snipe snipe merged commit 3fb543b into develop Nov 15, 2024
9 checks passed
@snipe snipe deleted the bug/sc-27500 branch November 15, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant