Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #15106: New Unaccepted Meta Status for Unaccepted Assets #15800

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NebelKreis
Copy link
Contributor

Description

This PR (currently in progress) introduces a feature that adds an Unaccepted status for assets assigned to users within Snipe-IT. Currently, there is no clear indication in the standard asset view or on the asset's main page to show whether a user has accepted or declined an asset. While there is an overview available for non-accepted assets, the only way to verify acceptance status otherwise is within individual assets by checking the asset history, which can be inconvenient and inefficient.

Key Changes:

  1. Unaccepted Status: When an asset is initially assigned to a user, it now enters an “Unaccepted” status, indicating the asset is deployed but not yet accepted by the user.
  2. Status Transitions:
    • Acceptance: Once the user confirms receipt, the status automatically changes to Deployed.
    • Rejection: If the user declines the asset, it reverts to Ready to Deploy, returning it to inventory as per the current workflow.

Features in Progress:

  1. Logic: The remaining work involves finalizing the logic for issuing, accepting, rejecting, and returning assets, ensuring that assets transition between the Unaccepted, Deployed, and Ready to Deploy statuses correctly.

Additionally, this screenshot below visualizes the feature in action:

Asset Acceptance Status Screenshot

Fixes Issue: #15106

Implementing this feature will improve asset tracking, streamline acceptance workflows, and reduce the administrative workload by providing automated follow-ups and clearer asset status visibility directly in the main asset views.

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Testing is currently in progress for the following items:

  • Manual Testing: Verified the transitions between “Unaccepted,” “Deployed,” and “Ready to Deploy” statuses to confirm proper functionality based on user actions.

Test Configuration:

  • PHP version: 8.1.2
  • MySQL version: 8.0.39
  • Webserver version: Apache 2.4.52
  • OS version: Ubuntu 24.04

Checklist:

Copy link

what-the-diff bot commented Nov 13, 2024

PR Summary

  • Enhanced Asset Status Tracking
    Updated methods statusMeta(), statusText() and fullStatusText() to cover a new scenario where an asset is designated to a user but not yet accepted.

  • Localization of New Status
    In order to provide a coherent user experience, a new translation for the term 'unaccepted' was added in the general language resource file general.php.

  • UI Adaptation for New Status
    Incorporated UI logic in the view.blade.php file to display the 'unaccepted' status with the asset details, when applicable.

  • Table Updates for New Status
    Extended support for the new 'unaccepted' status in bootstrap-table.blade.php, which includes its display in the table interface along with its styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant