Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed sortablity for current value column in depreciations report #15583

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Sep 30, 2024

Description

Removing the ability to sort by Current Value in the depreciation reports. They currently are updated through the presenter so, sorting them currently is not accurate. We are discussing how we can better handle this for the future.

Fixes #[sc-26924]

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from snipe as a code owner September 30, 2024 18:18
Copy link

what-the-diff bot commented Sep 30, 2024

PR Summary

  • Modification to "book_value" field attribute
    The attribute that allowed sorting of the "book_value" field has been changed. It is no longer possible to sort information by this field.

@snipe snipe merged commit b964ce1 into snipe:develop Sep 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants