Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed app settings view on mobile #15544

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Fixed app settings view on mobile #15544

merged 2 commits into from
Sep 24, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Sep 24, 2024

This fixes a layout issue on mobile when viewing the app configs in the settings index. It looked fine on full-size, but on xs screens, the "table" got out of whack.

Before

Screenshot_2024-09-20_at_5_44_48 PM

After

Screenshot 2024-09-24 at 10 54 38 AM Screenshot 2024-09-24 at 11 09 37 AM

@snipe snipe merged commit 8cf1e4d into develop Sep 24, 2024
7 of 9 checks passed
@snipe snipe deleted the bug/sc-26855 branch September 24, 2024 10:10
Copy link

what-the-diff bot commented Sep 24, 2024

PR Summary

  • Updated Settings Page Layout
    This PR incorporates design changes that improve the overall layout of the settings page. It comes with an enhanced structure for the containers and better styling for the rows which increases user-friendliness.
  • Introduced New Class for Row Styling
    With the addition of a new class called 'row-new-striped', row styling is significantly enhanced, promoting visual clarity and neatness.
  • Consistent Padding for Column Elements
    For an improved visual appearance, consistent padding has been added across various column elements, which ensures consistent and better spacing.
  • Better Alignment through Empty Columns
    To create a neater appearance and align elements perfectly, empty columns have been incorporated where necessary.
  • Improved Styling for Row Elements
    Lastly, the PR includes small tweaks in the styling of the row elements. While these changes may seem minor, they substantially enhance the overall aesthetic of the page without affecting its functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant