Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring modals with partials and fixing misalignments #15498

Merged
merged 10 commits into from
Sep 26, 2024

Conversation

Godmartinz
Copy link
Collaborator

@Godmartinz Godmartinz commented Sep 12, 2024

Description

Cleaned up modals; refactored code into partials for reuse, cleaned up input alignment.

Screenshots of all modals that have more than one input:

Location Modal:
image

Status Modal:
image

Model Modal:
image

User Modal:
image

Fixes #[sc-26707]

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Sep 12, 2024

PR Summary

  • Refactored Modal Forms for Common Elements
    Through this update, we have optimized the repeating sections of code in our modal forms (pop-up windows with information) into smaller, reusable parts called 'partials'. This includes elements such as name inputs, categories selection, and model numbers.

  • Reorganized User Modal with Partials
    The user modals, which provide user-related information, have been revised to use reusable pieces of code. This change makes the code easier to manage and apply changes in the future.

  • New Partials Introduced
    New reusable code elements have been introduced for categories, fieldset, and manufacturer selection. Also, model number input, name and email input sections have been converted into separate reusable components. This ensures more efficient code management and easier updates for these sections.

  • Revised Modal Footers
    The footers of the modals have been enhanced with a reusable footer partial, making this section of the code cleaner and easier to maintain.

  • Updated User Modal Styles
    The display settings for user modals have been revised for consistent appearance across the application.

@Godmartinz Godmartinz changed the title [WIP] Refactoring modals with partials and fixing misalignments Refactoring modals with partials and fixing misalignments Sep 25, 2024
@Godmartinz Godmartinz marked this pull request as ready for review September 25, 2024 19:54
@Godmartinz Godmartinz requested a review from snipe as a code owner September 25, 2024 19:54
@Godmartinz Godmartinz requested review from marcusmoore and snipe and removed request for snipe September 25, 2024 19:54
@snipe
Copy link
Owner

snipe commented Sep 25, 2024

Are those screenshots up to date? I'm not seeing the required indicators where I'd expect them to be, and I'd want those other select2 menus to reach all the way across to be even with the other text fields.

@marcusmoore
Copy link
Collaborator

marcusmoore commented Sep 25, 2024

Hm...yeah at least the create user modal lost the required indicators...

Here's what it is on develop:
user create modal

@Godmartinz
Copy link
Collaborator Author

Those were not the images you were looking for...all fixed! ✌️

@snipe snipe merged commit 9aada2e into snipe:develop Sep 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants