-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed a couple bugs in CustomFieldSetDefaultValuesForModel component #15486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # resources/views/livewire/custom-field-set-default-values-for-model.blade.php
PR Summary
|
Nice! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a couple bugs and adds some niceties to the
CustomFieldSetDefaultValuesForModel
component.🐛 Selecting a fieldset, checking the "Add default values" checkbox, and then selecting "No custom fields" would result in the fieldset default value fields still being shown:
🐛 Having checkboxes and radio buttons have the same values resulted in only the first group rendered on the page being selectable:
example-converted.mov
✨ "Add default values" is dynamic. It is hidden if no fieldset is selected, disabled if the selected fieldset does not have fields in it, and enabled if the selected fieldset has fields that can have default values assigned:
✨ In addition, when some input is entered and then the fieldset is changed the input is carried over if the field is present on the newly selected fieldset.
Before:
After:
Type of change