-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved layout: Set layout push/pull breakpoints to medium for alignment with columns #15459
Conversation
The new asset/consumable/user layout introduced in 95a0f3d and a few related commits splits the view into two blocks. On breakpoints XS and SM they're full-width 12-cell containers, while on MD, LG, XL they are 3-cell wide for the button column and 9-cell wide for the details table. Then, extra Bootstrap classes are used to push/pull them so that the button column is on the right. The push/pull classes were used with the SM breakpoint, while content was still 12-cell wide. This results in the SM breakpoint layout being broken - this commit makes these use the MD breakpoint instead.
💖 Thanks for this pull request! 💖 We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already. Examples of commit messages with semantic prefixes:
Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
PR Summary
|
Wasn't this fixed in #15352? |
@Godmartinz can you pull this branch down and test against your changes that were merged? |
Ohhh, okay, I did not test this against the current master/develop branch, just the stable one we're running. This probably won't hurt the resource/hardware views if applied, but it also fixes consumable/user views. The extra info-stack classes can be removed. |
Just not sure that with Godfrey's changes we'd still want to change that from |
@Godmartinz can you weigh in on this one? |
We went with adding an |
Okay, looks like this isn't needed then. |
Description
The new asset/consumable/user layout introduced in 95a0f3d and a few related commits splits the view into two blocks. On breakpoints XS and SM they're full-width 12-cell containers, while on MD, LG, XL they are 3-cell wide for the button column and 9-cell wide for the details table. Then, extra Bootstrap classes are used to push/pull them so that the button column is on the right.
The push/pull classes were used with the SM breakpoint, while content was still 12-cell wide. This results in the SM breakpoint layout being broken - this commit makes these use the MD breakpoint instead.
output.webm
Type of change
How Has This Been Tested?
Manually checked the CSS change on each affected page. This was changed live on our instance to unblock some people running the desktop layout on their phones.
Checklist: