Fixed custom field defaults being prematurely updated #15377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where attempting to update an asset model but getting a validation error still updated custom field default values even though the user is redirected back to the form:
custom.field.validation.issue.mp4
The issue was we were updating the custom field value defaults before calling
$model->save()
and a failure at model level validation means the user would be redirected back but the defaults had already been updated.We could probably update and utilize the
StoreAssetModelRequest
here but I found this as part of other work I'm doing and didn't want to get too distracted.Type of change