Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ) being added to expected asset checkin report email header #15336

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR fixes an issue where an extra ( was being added to the header of the expected asset checkin report email when Logo+Text was set for the branding option.

Before:
parentheses added to header

After:
parentheses removed

Fixes #15335

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

what-the-diff bot commented Aug 19, 2024

PR Summary

  • Enhanced Brand Check in Conditionals

An improvement has been made to the mailing system's code. Specifically, it's now added an extra verification step to check whether the brand field in the system settings is not equal to '1'. This brings an added layer of condition verification to ensure all parameters are met before the mailing system proceeds with its operations.

@snipe
Copy link
Owner

snipe commented Aug 19, 2024

Ah, dammit. I’m sure that was me - thanks for the fix. 😔

@snipe snipe merged commit 886514a into snipe:develop Aug 19, 2024
9 checks passed
@marcusmoore marcusmoore deleted the fixes/remove-displayed-parentheses branch August 19, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants