-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the 'sanitize' system for backup restores to the web GUI #15296
Conversation
PR Summary
Note: This summary might not cover all minor changes made. Please ensure to review the actual code changes for complete accuracy. |
Signed-off-by: snipe <[email protected]>
Fixed checkbox layout on modal from #15296
Signed-off-by: snipe <[email protected]>
We built the 'sanitize' system for doing backup restores, but really only exposed it in the CLI. We've even gone through some passes to improve it, somewhat, and so it's getting better. It's probably time to start exposing it in the UI.
Because we are changing a battle-tested system and adding some highly experimental features to it, I thought the checkbox for whether you're using it should default to 'off' - but there's a new
.env
-var that you can set to make the default be 'on'.Additionally, while I was going through the Javascript code that handles the 'restore' and 'delete' buttons, I simplified it a bit, making it shorter and more readable.
I'm marking this as draft because there are still some other fixes I want to sneak in there before it's ready. Namely, I need to fully test a backup that has prefixes, and I need to figure out why a local backup I have on my machine only runs with 'clean' mode turned off.
But I thought at least getting this up would give @snipe a chance to see how it looks and make suggestions on UI changes.