Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add missing admin/hardware/table.name key #15279

Merged

Conversation

FlorentDotMe
Copy link
Contributor

Description

The translation key admin/hardware/table.name is missing. This key is only used in the bulk delete view.

This patch only adds it in the en-US locale file.

Before:
image

After:
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Copy link

what-the-diff bot commented Aug 13, 2024

PR Summary

  • Addition of 'Asset Name' Column
    The code file responsible for managing hardware information has been updated with a new column labeled 'Asset Name'. This additional field offers the potential to input and display more details about specific hardware resources.

@snipe
Copy link
Owner

snipe commented Aug 13, 2024

We already have that translation somewhere else, so we should probably just re-use that one.

@FlorentDotMe FlorentDotMe force-pushed the fix_missing-translate-item-assets branch from 79a7c64 to 20e4ba0 Compare August 13, 2024 15:10
@FlorentDotMe
Copy link
Contributor Author

We already have that translation somewhere else, so we should probably just re-use that one.

Indeed the general dictionary contains the "asset_name" key.

@snipe
Copy link
Owner

snipe commented Aug 13, 2024

Is this ready to go? It's still in draft

@FlorentDotMe FlorentDotMe marked this pull request as ready for review August 13, 2024 15:34
@FlorentDotMe FlorentDotMe requested a review from snipe as a code owner August 13, 2024 15:34
@snipe
Copy link
Owner

snipe commented Aug 13, 2024

Looks great, thank you!

@snipe snipe merged commit def0af6 into snipe:develop Aug 13, 2024
7 of 9 checks passed
@FlorentDotMe FlorentDotMe deleted the fix_missing-translate-item-assets branch September 9, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants