Improve restore sanitization - Fixes [sc-24840] #15168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some older version of MySQL dump
INSERT
statements as:And we were unable to parse that.
Additionally, while MySQL can easily handle
\r\n
or\n
line-endings, our regex validator was getting confused by\r\n
, so now we trim them off and normalize them to just\n
.Also, since I was debugging the SQL sanitizer, I re-added back in a
--sql-stdout-only
command-line option that only sanitizes the SQL and dumps the result to STDOUT - which should make this easier to debug in the future.