Fixed start_date and end_date in user importer #15148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue involving start and end dates in the user importer.
If a row being imported does not have a start or end date, whether that is due to it not being mapped or not being included in the import at all, the fields would end up in the database as
0000-00-00
instead of null. TThis is due to the
findCsvMatch
method returning an empty string if the column is present but empty and/or callingtrim
on null returning an empty string.This PR simply changes
start_date
andend_date
fields to null if they have been set to an empty string after the initial matching/mapping.Fixes #15141
Type of change