Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing print user assigned filter #15059

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

A @endpush was added recently and seems to have been the culprit for losing the print assigned filter.
So because the print page does not load a layout, using @push/@endpush does not work. I removed these and we were able to get the filter to appear again.
image

Shoutout to @marcusmoore for his big brain.

Fixes #FD-42986

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

@Godmartinz Godmartinz requested a review from marcusmoore July 9, 2024 18:47
@Godmartinz Godmartinz requested a review from snipe as a code owner July 9, 2024 18:47
Copy link

what-the-diff bot commented Jul 9, 2024

PR Summary

  • Introduction of New Stylesheet and Script in print.blade.php
    The addition of the bootstrap-table.css stylesheet and bootstrap-table.js script enhances the presentation and interaction of our web page.

  • Modification to snipe-table class in print.blade.php
    The revision in the snipe-table class aims to improve performance and data manipulation features on the web page. The changes are as follows:

    • The css and js push directives have been removed, simplifying the code and making it more manageable.

    • A script has been added to tackle the Bootstrap table's lifecycle — it now has the ability to destroy and reload. This change will lead to more efficient handling of table data, specifically helping with updates, modifications, and overall responsiveness of the table.

    • Exporting data from the table has been revamped. The updated options provide a better user experience and increase productivity, by making data export tasks easier and more flexible for end-users.

Copy link
Collaborator

@marcusmoore marcusmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏾

@snipe snipe merged commit c58c592 into snipe:develop Jul 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants