Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #15037 - Removed custom fieldsets on auditing - it’s not used (yet) #15043

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 8, 2024

There was a regression introduced where we were apparently trying to handle custom field values on an audit, but we don't have the UI for that at this time so it was overwriting the custom field values on auditing. This at least removes that logic for now.

@snipe snipe merged commit ac9df2f into develop Jul 8, 2024
8 of 9 checks passed
Copy link

what-the-diff bot commented Jul 8, 2024

PR Summary

  • Removal of Encryption/Decryption Logic
    The team has eliminated a section of code within the AssetsController.php file that was previously responsible for managing the encryption and decryption of some asset information. This change suggests a move towards a more efficient or more secure means of handling sensitive data.

  • Adjustment in Array Input Handling
    In the previous version, there was code in place to convert array inputs into string format. This piece of code was removed, which could indicate a change in the structure of data or the method of data input that the system accepts.

  • Code Cleaning
    Adding a blank line after the removal of certain codes signifies clean coding habits. This is part of regular code maintenance to ensure that our software is readable and easily maintainable for maximum productivity.

@snipe snipe deleted the fixes/custom_fields_on_audit branch July 8, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant