Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed non-counts from allowed array #15021

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 3, 2024

This removes the assets, etc items from the allowed columns, since they should be referred to by their *_count alias, so they match what we load using the ->withCount('assets as assets_count', 'licenses as licenses_count', 'accessories as accessories_count', 'consumables as consumables_count', 'managesUsers as manages_users_count', 'managedLocations as manages_locations_count'); part of the request.

This isn't really a breaking change though, since passing any of those would have just caused a 500 anyway.

Copy link

what-the-diff bot commented Jul 3, 2024

PR Summary

  • Simplification of User Information
    The change is about decreasing the amount of information provided by the user's profile on our service. The 'assets', 'accessories', 'consumables', and 'licenses' fields are removed from user data. This can make user personal page simpler and decrease the complexity of the data we provide. It’s a move towards enhancing data security and privacy by restricting unnecessary user details from being exposed.

Signed-off-by: snipe <[email protected]>
@snipe snipe merged commit f22c3cd into develop Jul 3, 2024
8 of 9 checks passed
@snipe snipe deleted the fixes/removed_non_counts branch July 3, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant