Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a file tab on a Company #15003

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

ralphmodales
Copy link

@ralphmodales ralphmodales commented Jul 2, 2024

Description

Adding a file tab on a Company based on the file uploads of asset and users, and company. This is to check for the falls of the assets and a user of a company.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Check the Company tab and there's a file option for it.

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Based on the file uploads of asset and users, and company.
@ralphmodales ralphmodales requested a review from snipe as a code owner July 2, 2024 03:36
Copy link

welcome bot commented Jul 2, 2024

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

what-the-diff bot commented Jul 2, 2024

PR Summary

  • Introduction of 'Company.php' File
    In order to manage and process details related to companies, a new file called Company.php has been introduced. This file will aid in the handling of company-related operations and serve as a centralized location for code that deals with company information.

@snipe
Copy link
Owner

snipe commented Jul 3, 2024

I'm not really sure what's happening in this - we already have a Company model and view, so not sure why they'd be added here. (Also please make sure you submit PRs against develop, not master.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants