Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added #14997: Display department manager in user view and list #14998

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

timoschwarzer
Copy link

@timoschwarzer timoschwarzer commented Jul 1, 2024

Description

This PR displays Department Managers in both the user view and user list.

image

image

Fixes #14997

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual test by running the development environment in a container

Test Configuration:

  • PHP version: 8.1 (Dockerfile.alpine in the repository)
  • MySQL version: mariadb:10.6.4-focal (dev.docker-compose.yml in the repository)
  • Webserver version: Apache (Dockerfile.alpine in the repository)
  • OS version: Alpine 3.18.6 (Docker)

Checklist:

@timoschwarzer timoschwarzer requested a review from snipe as a code owner July 1, 2024 13:59
Copy link

welcome bot commented Jul 1, 2024

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

what-the-diff bot commented Jul 1, 2024

PR Summary

  • Introduction of Department Manager Information
    This update includes a new piece of data, the department_manager, in how we form user profiles.

  • Enhancement of User Data Presentation
    In order to accommodate this new information, the layout of our user data table has been adjusted. The department manager details will now be a feature of this table.

  • Improved Viewing Experience in User View
    Finally, the user view section has been updated with a new conditional statement in its code. This will allow the department manager data to be visible, adding an extra layer of valuable information to the user interface. This will help users have access to more comprehensive information regarding their department organization.

@timoschwarzer timoschwarzer changed the title Add Department Manager to single and multiple user views Add Department Manager to user view and user list Jul 1, 2024
@timoschwarzer timoschwarzer changed the title Add Department Manager to user view and user list Added #14997: Display department manager in user view and list Jul 1, 2024
@timoschwarzer timoschwarzer changed the base branch from master to develop July 1, 2024 14:05
@timoschwarzer timoschwarzer force-pushed the feature/department-manager-in-table branch from bea2f0e to 9140588 Compare July 1, 2024 14:07
@timoschwarzer timoschwarzer force-pushed the feature/department-manager-in-table branch from 9140588 to 0977459 Compare July 1, 2024 14:08
@@ -511,6 +511,19 @@
</a>
</div>
</div>
@if($user->department->manager)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a user doesn't have a department, I think this would 500 here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wouldn't because of the check in line 502 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Department Manager in User Overview and User Details
2 participants