Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ad-Hoc Notes on Assets #14987

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Conversation

akemidx
Copy link
Collaborator

@akemidx akemidx commented Jun 27, 2024

Description

The ability to add a note to an asset uncoupled from an action (such as Checkin)

A pop-up window will open, and the note will save to the Asset History (as well as the activity log)

Screenshot 2024-06-27 at 5 36 35 PM Screenshot 2024-06-27 at 5 38 05 PM Screenshot 2024-06-27 at 5 38 59 PM

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

  • I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview

  • I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines

  • My code follows the style guidelines of this project

  • I have performed a self-review of my own code

  • I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation

  • My changes generate no new warnings

  • I have added tests that prove my fix is effective or that my feature works

  • New and existing unit tests pass locally with my changes

Copy link

what-the-diff bot commented Jun 27, 2024

PR Summary

  • Addition of a New Note System
    A series of new files and updates to existing files were made to integrate a new note-taking system into the application. This will help users remain organized and keep track of important details when interacting with the system.

  • Creation of New Event - "Note Added"
    The update introduces a new event named 'Note Added'. Essentially, when a user adds a note, this event will be triggered within the system, allowing for various responses to be programmed in as per need.

  • Incorporation of Notes Controller
    A dedicated controller for notes has been created. This ensures that all note-related actions such as creating a new note, updating an existing note etc will be handled by this specific controller, thereby maintaining a cleaner and more organized codebase.

  • Introduction of New Section for Notes
    Changes have been made to the user interface. Specific sections for adding notes have been introduced in the hardware and license views. This makes it easier for users to add notes while reviewing their hardware and licenses.

  • New Route for Storing Notes
    A new route has been created in the system purely for managing note storage, ensuring the efficient handling of note-related data traffic.

  • Introduction of Translation String
    A translation string for 'note added' has been introduced, as a part of localization strategies implying the new feature may be intended for use by an international audience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant