Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the user exists before trying to fill the request #14982

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 27, 2024

This better handles trying to PATCH or PUT on a user via the API where that user ID does not exist.

Copy link

what-the-diff bot commented Jun 27, 2024

PR Summary

  • Improved Security Features in the User Management System
    Various rules have been implemented to ensure no unwanted changes are performed. This includes preventing users from changing administrative-level information in the demo use-case and any possible updates to user information through the API while in demo mode. Moreover, steps have been taken to prevent users from making themselves their own manager, preserving the defined system hierarchy.

  • Streamlined Location and Group Updates
    The system has been programmed to automatically update the location of the resources linked to a specific user whenever any alteration to user data is made. If the user is identified as a superuser and there are specifications regarding group changes in the request, the changes will be done automatically.

  • Enhanced User Customization
    Changes have been made to allow users to upload images for their avatar. This will provide users with added customization options and enhance the overall user experience.

  • Improved Response Handling
    Additional responses have been added to handle various situations, such as successful updates, save errors, and instances where user data could not be found. This will improve the system's ability to alert the user about the status and outcome of their actions promptly.

  • Code Refactoring and Formatting
    The code has been optimized and reformatted for better readability, easy maintenance, and improved performance.

@snipe
Copy link
Owner Author

snipe commented Jun 27, 2024

Not sure how this would have broken tests exactly...

Signed-off-by: snipe <[email protected]>
@snipe snipe merged commit b6e8d28 into develop Jun 27, 2024
9 checks passed
@snipe snipe deleted the fixes/check_for_user_on_patch_api branch June 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant