Fixed #14895 and #14919 - set SAML baseurl to a sensible default for docker users and users behind a reverse proxy #14974
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users who are running Snipe-IT behind a reverse-proxy, the SAML implementation guesses an incorrect
baseurl
(as http:// rather than https://). This change sets it to a default based on theAPP_URL
- which we rely on elsewhere, as well as here within the SAML code itself. So this should be pretty safe.