Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more try at sticky header and columns #14939

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 23, 2024

This is getting closer... sticky headers (which we already have) is now placing a little bit nicer with the sticky column, but I think we still need to re-render the table after that's been changed, as things get weird any time you click on a column header to sort or search. :-(

I also messed around with enabling the reorderableColumns: true, again in partials/bootstrap-tables.blade.php, shit got real froggy with all three of them. Maybe someone like @uberbrady can tinker with it a bit and figure out if we can make the callbacks work to re-paint the table.

@probot-autolabeler probot-autolabeler bot added css dependencies Pull requests that update a dependency file frontend javascript skins labels Jun 23, 2024
Copy link

what-the-diff bot commented Jun 23, 2024

PR Summary

  • Updated Library

    • The version of "bootstrap-table" was updated to improve functionality and fix possible bugs.
  • Improved CSS Readability

    • The CSS files for signature-pad, skin-black, and similar files were organized and annotated for better readability.
  • Skin Theme Adjustments

    • Various color and style changes were made to the skin-blue, skin-contrast, skin-green, skin-orange, skin-red, skin-purple, and skin-yellow themes to enhance the user interface and improve user experience.
  • Improvements to Skin Visuals

    • This includes change in colors for navigation bars, sidebars, buttons, text and links etc., depending upon the specific themes.
  • New CSS Styles

    • New CSS styles were introduced for the "Purple" skin to diversify our theme options, improving customizability for users.
  • Application File Updates

    • The public/mix-manifest.json, resources/views/partials/bootstrap-table.blade.php, and webpack.mix.js files were updated. This likely optimizes our application's performance and functionality.
  • Additional Features for Bootstrap Tables

    • The changes in webpack.mix.js file indicate addition of features like 'table-fixed-columns' and 'table-reorder-columns'. This could make data analysis easier for the users.

@snipe snipe changed the title One more try at sticker header and columns One more try at sticky header and columns Jun 24, 2024
@snipe snipe requested a review from uberbrady June 27, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css dependencies Pull requests that update a dependency file frontend javascript skins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant