Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unable to install on PHP 8.1 #14900

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR fixes an issue with installing composer packages on PHP 8.1 that was introduced in #14899.

I think that PR included a composer update that was run on 8.2 and ended up locking files to a 8.2 minimum. I reverted that commit, switched my local version to 8.1, ran composer require barryvdh/laravel-debugbar, and composer prompted me to simply move the dependency from require-dev to require without updating other packages.

I switched back to 8.2 and was able to install there without problems as well.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@marcusmoore marcusmoore requested a review from snipe as a code owner June 18, 2024 16:49
@probot-autolabeler probot-autolabeler bot added backend dependencies Pull requests that update a dependency file labels Jun 18, 2024
@marcusmoore marcusmoore marked this pull request as draft June 18, 2024 16:55
@marcusmoore marcusmoore marked this pull request as ready for review June 18, 2024 16:57
@snipe snipe merged commit b8882fa into snipe:develop Jun 18, 2024
8 checks passed
@marcusmoore marcusmoore deleted the fixes/81-install branch June 18, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants