Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing } #14884

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

marcusmoore
Copy link
Collaborator

Description

This PR adds a missing } in ActionlogController. It looks like it was introduced in a recent PR #14827.

I haven't actually tested the s3 branch of the switch statement but the default branch works as expected.

For reference the } on line 35 is actually closing the { on line 19 and not the method like it should:
Reference for mismatched brackets

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

what-the-diff bot commented Jun 17, 2024

PR Summary

  • Enhancement in ActionlogController
    • This update added new conditions to handle different types of storage scenario, one specific for 's3' storage, and a default one for all the other types. This increases the flexibility and adaptability of our system.
  • Addition of the getStoredEula method
    • A new method 'getStoredEula' has been introduced. This improvement is aimed at getting the stored End-User License Agreement(EULA) more efficiently, resulting in a smoother user experience.

@snipe snipe merged commit cd5bef4 into snipe:develop Jun 18, 2024
7 of 8 checks passed
@marcusmoore marcusmoore deleted the fix/actionlogcontroller-fix branch June 18, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants