Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed icon, added translation #14766

Merged
merged 2 commits into from
May 25, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented May 25, 2024

We were previously using a trash icon for the UI element to remove a custom field from a fieldset, which was mostly okay, but it could be confusing, since hitting the trash icon there doesn't delete the field itself, just the relationship with the fieldset. Switching to a "minus" symbol makes this a little clearer.

Copy link

what-the-diff bot commented May 25, 2024

PR Summary

  • Introduction of a New Translation Key
    A new translation key named remove_customfield_association has been integrated into the language file general.php. This enhances our app's multilingual support, making it more accessible to a wider audience.

  • Modification in User Interface Elements
    There have been visual modifications in the view.blade.php file. Specifically, both the tooltip and icon of a certain button have been altered. This change is intended to improve user experience, making interaction with the application more intuitive and efficient.

@snipe snipe merged commit 29cd75a into snipeit_v7_laravel10 May 25, 2024
6 of 7 checks passed
@snipe snipe deleted the chore/sc-25656/minus_icon_for_fieldsets branch May 25, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant