Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicer handling of erroring when filename+log do not match #14752

Merged
merged 4 commits into from
May 22, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented May 22, 2024

This is a bit of a fringe case, but sometimes it happens that in the User > User Files section, there is a file that exists but no matching file on the server, or vice versa. This is usually due to a restore or manually edited data, but we weren't accounting for it before and would 500. Now we give a nice error message.

Copy link

what-the-diff bot commented May 22, 2024

PR Summary

  • Additional Verification for User Existence
    Before deleting any user data, this update adds an extra layer of verification to confirm that the user exists in the first place. This contributes to the overall integrity of the data and service.

  • Modified Delete Authorization Check
    The authorization process for deleting user files has been adjusted to align more precisely with our updated security standards.

  • Updated File Destination Path
    The storage location for uploaded files has been shifted. This change helps us organize and manage files more effectively.

  • Enhanced File and Action Log Deletion Process
    We have reworked the method of deleting files and their accompanying action logs, ensuring a more clean and thorough removal of data.

  • Added Validation for File Existence before Deletion
    We are ensuring the existence of files before attempting any deletion. This can prevent unnecessary errors and improve efficiency.

  • Improved Messages after File Deletion
    The user will now receive a more informative message following successful file deletion, enhancing user experience.

  • Updated User not Found Error Message
    In cases where the user cannot be found, the error message has been updated to better communicate the issue.

  • Improved Redirect after User Not Found
    If a user is not found, the redirection process has been revised to better manage the situation.

@snipe snipe merged commit d3798bf into develop May 22, 2024
9 checks passed
@snipe snipe deleted the fixes/better_handle_data_file_mismatch_in_user_files branch May 22, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant