Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only attempt to decrypt custom fields in activity log if the value is not empty #14728

Merged
merged 1 commit into from
May 16, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented May 16, 2024

This just cuts down a bit on the extra debug logging by only attempting the try { if there's actually a value for the field. (Nothing to decrypt otherwise.)

@snipe snipe merged commit 4119526 into develop May 16, 2024
8 of 9 checks passed
Copy link

what-the-diff bot commented May 16, 2024

PR Summary

  • Improved Error Handling in ActionlogsTransformer.php
    A more robust conditional check has been added to a transform operation in ActionlogsTransformer.php, ensuring that it only proceeds if required data exists. This enhances the application's stability by reducing the chance of encountering unexpected errors.

  • Enhanced Error Messaging
    Error messages have been refined in ActionlogsTransformer.php, providing clearer indications when an issue arises, such as undecipherable data due to potential changes in encryption keys.

  • Removal of Redundant Debug Log
    A superfluous debug log, "custom fields do not match," has been removed, simplifying the debugging process by reducing irrelevant information.

  • Better Security Measures for Meta Data
    In the event of a mismatch between old and new encrypted data, the related meta data is now hidden and replaced with "************". This strengthens the security by ensuring sensitive encrypted information isn't inadvertently exposed.

@snipe snipe deleted the fixes/smarter_decryption_in_activity branch May 16, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant