-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic encrypted custom fields support for checkboxes - needs testing, tests, and love #14721
base: develop
Are you sure you want to change the base?
Conversation
PR Summary
|
@uberbrady I got some initial tests for non-encrypted checkbox testing, and found a problem on the first test I started writing for encrypted checkbox. There's a note in the validator about it. From memory, this is the problem I had when I was writing this validator initially and why I started questioning the encrypted checkbox in the first place. From what I remember, I was having problems consistently decrypting I stopped when I remembered I couldn't really test it without going and re-enabling the feature on the front end to get an encrypted checkbox set up, so I'll get back to that in the morning. Or maybe later tonight if I can't sleep again. |
Thank you for the tests! Let me see if there's anything I can help with. |
DONT MERGE Found a pretty significant issue with this that needs attention first. We can talk on Monday. |
Alright, I think that was a false alarm, sorry - I was trying to check an asset out and was failing encrypted checkbox validation, but that's actually happening on dev, not this branch. Seems like a backwards-compatibility issue if I've set encrypted checkbox data and switch back to dev - which makes sense. |
Probably slightly related to this: #14720 Tho based on internal conversations, the encryption part isn't really the issue here 😬 ) |
Sometimes some customers might choose to encrypt custom fields that are just a collection of checkboxes. We should be able to support that.