-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed threshold explanation and min qty math #14601
base: develop
Are you sure you want to change the base?
Conversation
PR Summary
|
Wouldn't we want to apply this to all of the spots where we use minimum quantities? |
updates min qty in tables in transformers and edit and create methods
@snipe changes applied to the partial blade. controllers and transformers updated as well 🙂 |
used partial again on asset model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍🏾
(didn't run in browser since we have other reviewers checking it out as well)
public static function sumThreshold($min_qty = null){ | ||
|
||
return $min_qty + Setting::getSettings()->alert_threshold; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a hunch this method name can be improved but I don't have a good suggestion...
@snipe is this good? |
Description
This changes the min qty on Asset models, Components, Accessories, Consumables and Licenses to 'Increase Alert Threshold' giving a better understanding of how this value will interact with the Settings threshold. The Helper text has been updated as well. Also the way the
min_amt
is calculated in the notification center has been updated to total the asset model and settting threshold values.A Helper method was made to better handle the sum for transformers.
Fixes #14604 [sc-25227]Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: