Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ldap location syncing incorrect locations for users. #14559

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This change clears out the $location variable before syncing the next user. It is created if a new location is made. and it stays populated for the next user, which is unnecessary and wrong. This change clears the variable before the next user is synced and syncs locations correctly now.

Fixes #14506 [sc-25238]

Type of change

Please delete options that are not relevant.

  • [ x] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

This pull request has been linked to Shortcut Story #25238: Ldap Location sync malfunctioning..

Copy link

what-the-diff bot commented Apr 4, 2024

PR Summary

  • Addition of initialization value to the '$location' variable
    A new line has been added to a file responsible for synchronization tasks to initialize a variable named '$location' with a value of 'null'. This means the variable is made ready for use and does not contain any specific value from the start.

@snipe snipe merged commit 3bed04a into snipe:develop Apr 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants